Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifier #173

Closed
wants to merge 23 commits into from
Closed

Verifier #173

wants to merge 23 commits into from

Conversation

themighty1
Copy link
Member

@themighty1 themighty1 commented Jan 26, 2023 •
edited
Loading

The Verifier of the notarization document.

See tests/integration_test.rs for an end-to-end test.

I did not write tests for verification failure conditions and for document validation errors. All other tests are present. I will add the missing tests as a separate commit once this PR is ACKed.

sinui0
sinui0 reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good, I left some comments mostly around naming. Will re-review after changes as discussed in discord regarding label order/removing block semantics

verifier/src/tls_doc.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/tls_doc.rs Outdated Show resolved Hide resolved
verifier/src/commitment.rs Outdated Show resolved Hide resolved
verifier/src/commitment.rs Outdated Show resolved Hide resolved
verifier/src/commitment.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/commitment.rs Outdated Show resolved Hide resolved
@themighty1
Copy link
Member Author

@th4s , all sinu's comments have been addressed. I will not be adding any new commits.

@themighty1 themighty1 requested a review from th4s February 1, 2023 16:35
th4s
th4s requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

I think it would be good to have some more unit tests for this crate, because there are some modules without any tests. We should also fix the warnings from cargo check when compiling.

verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/checks.rs Outdated Show resolved Hide resolved
verifier/src/checks.rs Outdated Show resolved Hide resolved
verifier/src/checks.rs Outdated Show resolved Hide resolved
verifier/src/commitment.rs Outdated Show resolved Hide resolved
verifier/src/label_encoder.rs Outdated Show resolved Hide resolved
verifier/src/label_encoder.rs Outdated Show resolved Hide resolved
verifier/src/signed.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 added this to the Notarize! milestone Feb 7, 2023
@themighty1
Copy link
Member Author

All feedback was addressed. I had to break down the document into more testable chunks and make mpc-core a dev dependency.
No functional changes were made in the last 2 commits except only verify_label_commitments was simplified

tlsn/verifier/transcript_verifier/src/doc/validated.rs

Line 139 in c70ac63

fn verify_label_commitments(&self) -> Result<(), Error> {

@themighty1
Copy link
Member Author

I opened the issue for rs_merkle antouhou/rs-merkle#20
Will keep using rs_merkle as is for now.
The panicking test is commented out for now

tlsn/verifier/transcript_verifier/src/doc/validated.rs

Line 407 in c70ac63

fn verify_merkle_proofs_fail_wrong_leaf_count(mut validated_doc: ValidatedDoc) {

@themighty1 themighty1 requested review from th4s and sinui0 February 13, 2023 16:42
@themighty1
Copy link
Member Author

@sinui0 , adding you to review since some changes happened since your last review.

sinui0
sinui0 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple small things

verifier/transcript-verifier/src/verified_transcript.rs Show resolved Hide resolved
verifier/transcript-verifier/src/utils.rs Show resolved Hide resolved
th4s
th4s approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice work, ack

verifier/transcript-verifier/src/doc/mod.rs Show resolved Hide resolved
verifier/transcript-verifier/src/doc/unchecked.rs Show resolved Hide resolved
transcript-core/src/commitment.rs Show resolved Hide resolved
@themighty1 themighty1 mentioned this pull request Mar 13, 2023
Merged
@themighty1 themighty1 mentioned this pull request May 2, 2023
Merged
@themighty1
Copy link
Member Author

closing, superseded by #232

@themighty1 themighty1 closed this May 2, 2023
@sinui0 sinui0 deleted the verifier_local branch May 23, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinui0 sinui0 sinui0 approved these changes

@th4s th4s th4s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Notarize!
Development

Successfully merging this pull request may close these issues.
3 participants
@themighty1 @th4s @sinui0